Skip to content

Scaffold: correct import#40998

Merged
balloob merged 2 commits intodevfrom
scaffold_template-1
Oct 2, 2020
Merged

Scaffold: correct import#40998
balloob merged 2 commits intodevfrom
scaffold_template-1

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

Breaking change

Proposed change

I am not 100% sure about this.
But I think state should be imported from homeassistant.components.homeassistant.triggers

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added Hacktoberfest small-pr PRs with less than 30 lines. labels Oct 1, 2020
Copy link
Copy Markdown
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks correct to me.
The proposed update to the scaffold file matches an example:
/homeassistant/components/fan/device_trigger.py

@Danielhiversen Danielhiversen changed the title import state from homeassistant.components.homeassistant.triggers Scaffold: correct import Oct 2, 2020
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's correct. We changed that in 115.

@balloob balloob merged commit 9d3ddb8 into dev Oct 2, 2020
@balloob balloob deleted the scaffold_template-1 branch October 2, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Hacktoberfest small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants