Replace minecraft translation strings with reference strings#40997
Merged
Conversation
Contributor
|
Hi @MatejMecka, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Member
|
We need to rebase this branch on latest dev branch when the PR that adds the name key has been merged. |
Contributor
Author
|
@MartinHjelmare Should I submit a Pull Request adding this line or is there another PR awaiting to be merged? |
Member
|
Name is added in this PR that's not merged yet. I thought you had seen that and that's why you used that key already in this PR. |
Contributor
Author
|
😅 Yes, I have used it from there. I just forgot. Sorry for using up your time |
springstan
reviewed
Oct 3, 2020
1b601b0 to
d13e3d3
Compare
MartinHjelmare
approved these changes
Oct 3, 2020
ronanmu
pushed a commit
to ronanmu/home-assistant
that referenced
this pull request
Oct 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
N/A
Proposed change
This Change is part of #40578 to use Reference Strings in as many places as possible. This PR is for the Minecraft Integration only.
Type of change
Example entry for
configuration.yaml:N/A
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: