Skip to content

Replace minecraft translation strings with reference strings#40997

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
MatejMecka:patch-2
Oct 3, 2020
Merged

Replace minecraft translation strings with reference strings#40997
MartinHjelmare merged 1 commit into
home-assistant:devfrom
MatejMecka:patch-2

Conversation

@MatejMecka
Copy link
Copy Markdown
Contributor

Breaking change

N/A

Proposed change

This Change is part of #40578 to use Reference Strings in as many places as possible. This PR is for the Minecraft Integration only.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

N/A

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @MatejMecka,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @elmurato, mind taking a look at this pull request as its been labeled with an integration (minecraft_server) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MatejMecka MatejMecka changed the title Replace Supported strings with Reference Strings Replace Supported strings with Reference Strings in Minecraft Server Oct 1, 2020
@MartinHjelmare MartinHjelmare changed the title Replace Supported strings with Reference Strings in Minecraft Server Replace minecraft translation strings with reference strings Oct 1, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Copy Markdown
Member

We need to rebase this branch on latest dev branch when the PR that adds the name key has been merged.

@MatejMecka
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare Should I submit a Pull Request adding this line or is there another PR awaiting to be merged?

@MartinHjelmare
Copy link
Copy Markdown
Member

Name is added in this PR that's not merged yet.
#40947

I thought you had seen that and that's why you used that key already in this PR.

@MatejMecka
Copy link
Copy Markdown
Contributor Author

MatejMecka commented Oct 1, 2020

😅 Yes, I have used it from there. I just forgot. Sorry for using up your time

Comment thread homeassistant/components/minecraft_server/strings.json
@MartinHjelmare MartinHjelmare self-assigned this Oct 3, 2020
@MartinHjelmare MartinHjelmare merged commit 4fea7c6 into home-assistant:dev Oct 3, 2020
ronanmu pushed a commit to ronanmu/home-assistant that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants