Use references in guardian strings.json

[daveychu]

Proposed change

Use references in guardian strings.json

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue: Translations: Use references in config flow #40578
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[homeassistant]

Hi @daveychu,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @bachya, mind taking a look at this pull request as its been labeled with an integration (guardian) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[SNoof85]

I think there can be more keys to do in this one :

• already_configured
• already_in_progress
• connection_error can be cannot_connect

[daveychu]

I think there can be more keys to do in this one :

• already_configured
• already_in_progress
• connection_error can be cannot_connect

Which reference do you propose for already_in_progress? Not sure which one suits here and other strings.json don't reference anything yet either.

[SNoof85]

I think there can be more keys to do in this one :

• already_configured
• already_in_progress
• connection_error can be cannot_connect

Which reference do you propose for already_in_progress? Not sure which one suits here and other strings.json don't reference anything yet either.

Yes right, the already_in_progress is not yet implemented (see #40961).
It will be changed with the mentionned PR, so please do not take care of what i've said for this one :)

Otherwise looks good for others ! 👍

[SNoof85]

See suggestion 👍

[SNoof85]

Oh my bad, one more thing :

Suggested change

	"connection_error": "[%key:common::config_flow::error::cannot_connect%]"
	"cannot_connect": "[%key:common::config_flow::error::cannot_connect%]"

And update config_flow.py and tests to reflect this change

[SNoof85]

👍

[bachya]

🙏