Skip to content

Fix Rachio switch state when paused#40984

Merged
bdraco merged 2 commits intohome-assistant:devfrom
brg468:rachio-switch-fix
Oct 1, 2020
Merged

Fix Rachio switch state when paused#40984
bdraco merged 2 commits intohome-assistant:devfrom
brg468:rachio-switch-fix

Conversation

@brg468
Copy link
Copy Markdown
Contributor

@brg468 brg468 commented Oct 1, 2020

Proposed change

Currently when a schedule run is paused, the switch for the zone that was running remains in the on position even though at that point the zone itself is no longer running. Fixes an issue where if a schedule is stopped during a pause condition the switch would remain on.

Schedule switches will continue to stay on during a pause as the schedule is still technically running.

1 formatting change was also included.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as its been labeled with an integration (rachio) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Oct 1, 2020

Tested OK 👍

@bdraco bdraco merged commit 40ea30d into home-assistant:dev Oct 1, 2020
@brg468 brg468 deleted the rachio-switch-fix branch October 1, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants