Skip to content

Replace IP Address in strings.json#40968

Merged
ludeeus merged 2 commits intohome-assistant:devfrom
MBlokhuijzen:ip_address_strings
Oct 1, 2020
Merged

Replace IP Address in strings.json#40968
ludeeus merged 2 commits intohome-assistant:devfrom
MBlokhuijzen:ip_address_strings

Conversation

@MBlokhuijzen
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, @jrester, mind taking a look at this pull request as its been labeled with an integration (powerwall) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your copy+paste missed a few things 👍

Comment thread homeassistant/components/powerwall/strings.json Outdated
Comment thread homeassistant/components/ps4/strings.json Outdated
Comment thread homeassistant/components/denonavr/strings.json Outdated
@probot-home-assistant
Copy link
Copy Markdown

Hey there @vangorra, mind taking a look at this pull request as its been labeled with an integration (gogogate2) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bachya, mind taking a look at this pull request as its been labeled with an integration (guardian) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @ktnrg45, mind taking a look at this pull request as its been labeled with an integration (ps4) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MBlokhuijzen
Copy link
Copy Markdown
Contributor Author

Looks like your copy+paste missed a few things +1

Thanks for reviewing and spotting them!

@ludeeus ludeeus merged commit 2a05fe7 into home-assistant:dev Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants