Add longitude and latitude common strings#40963
Merged
springstan merged 4 commits intohome-assistant:devfrom Oct 1, 2020
SNoof85:lon_lat
Merged
Add longitude and latitude common strings#40963springstan merged 4 commits intohome-assistant:devfrom SNoof85:lon_lat
springstan merged 4 commits intohome-assistant:devfrom
SNoof85:lon_lat
Conversation
bieniu
approved these changes
Oct 1, 2020
| "api_key": "API Key" | ||
| "api_key": "API Key", | ||
| "longitude": "Longitude", | ||
| "latitude": "Latitude" |
Member
There was a problem hiding this comment.
When we add new common keys for items that are already translated it's good to rename the keys in lokalise for the existing translations too. Someone with admin access in lokalise needs to do that.
Member
There was a problem hiding this comment.
Do we know who has admin access to do that?
Member
There was a problem hiding this comment.
Commenting here so we don't forget.
Member
There was a problem hiding this comment.
I just know Paulus but there should be more admins.
This was referenced Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Adding longitude and latitude to the common strings and use them in config flows
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: