Skip to content

Clean up goalzero#40817

Merged
MartinHjelmare merged 6 commits intohome-assistant:devfrom
tkdrob:goalzero
Oct 1, 2020
Merged

Clean up goalzero#40817
MartinHjelmare merged 6 commits intohome-assistant:devfrom
tkdrob:goalzero

Conversation

@tkdrob
Copy link
Copy Markdown
Contributor

@tkdrob tkdrob commented Sep 30, 2020

Breaking change

Proposed change

@MartinHjelmare

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • x ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title cleanup goalzero code Clean up goalzero Sep 30, 2020
Comment thread homeassistant/components/goalzero/binary_sensor.py Outdated
Comment thread homeassistant/components/goalzero/config_flow.py Outdated
Comment thread homeassistant/components/goalzero/__init__.py Outdated
Comment thread homeassistant/components/goalzero/config_flow.py Outdated
@tkdrob tkdrob marked this pull request as ready for review October 1, 2020 02:30
@MartinHjelmare
Copy link
Copy Markdown
Member

Good! Just update _async_endpoint_existed too to have consistent return values. Return None if no match is found.

Comment thread homeassistant/components/goalzero/config_flow.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 6627fff into home-assistant:dev Oct 1, 2020
@tkdrob tkdrob deleted the goalzero branch October 1, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants