Seperate state change tracking from async_track_template_result into async_track_state_change_filtered#40803
Merged
balloob merged 1 commit intohome-assistant:devfrom Oct 1, 2020
Conversation
932b0eb to
d4f9aee
Compare
…async_track_filtered_state_change
d4f9aee to
86df486
Compare
21 tasks
balloob
approved these changes
Oct 1, 2020
Member
|
Tagged for milestone or else we can't cherry pick #40667 |
balloob
pushed a commit
that referenced
this pull request
Oct 1, 2020
…async_track_state_change_filtered (#40803)
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The code driving
async_track_template_resultwas growing in scope and becomingdifficult to maintain. This change separates the management of the state change
subscriptions into a new class.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: