Skip to content

Seperate state change tracking from async_track_template_result into async_track_state_change_filtered#40803

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:seperate_filtered_state_changed_event_tracking
Oct 1, 2020
Merged

Seperate state change tracking from async_track_template_result into async_track_state_change_filtered#40803
balloob merged 1 commit intohome-assistant:devfrom
bdraco:seperate_filtered_state_changed_event_tracking

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Sep 30, 2020

Proposed change

The code driving async_track_template_result was growing in scope and becoming
difficult to maintain. This change separates the management of the state change
subscriptions into a new class.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as draft September 30, 2020 19:24
@bdraco bdraco force-pushed the seperate_filtered_state_changed_event_tracking branch 2 times, most recently from 932b0eb to d4f9aee Compare September 30, 2020 20:55
@bdraco bdraco changed the title Seperate state change tracking from async_track_template_result into async_track_filtered_state_change Seperate state change tracking from async_track_template_result into async_track_state_change_filtered Sep 30, 2020
@bdraco bdraco force-pushed the seperate_filtered_state_changed_event_tracking branch from d4f9aee to 86df486 Compare September 30, 2020 20:56
@bdraco bdraco marked this pull request as ready for review September 30, 2020 20:57
@bdraco bdraco mentioned this pull request Sep 30, 2020
21 tasks
@balloob balloob merged commit 7285c78 into home-assistant:dev Oct 1, 2020
@balloob balloob added this to the 0.116.0 milestone Oct 1, 2020
@balloob
Copy link
Member

balloob commented Oct 1, 2020

Tagged for milestone or else we can't cherry pick #40667

balloob pushed a commit that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants