Accept new Plex websocket callback payloads#40773
Merged
balloob merged 3 commits intohome-assistant:devfrom Oct 1, 2020
Merged
Accept new Plex websocket callback payloads#40773balloob merged 3 commits intohome-assistant:devfrom
balloob merged 3 commits intohome-assistant:devfrom
Conversation
Reload integration on errors Reduce logging on errors during setup
Kane610
reviewed
Sep 30, 2020
Kane610
reviewed
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Relies on changes in library: jjlawren/python-plexwebsocket@v0.0.11...v0.0.12
Accepts new payloads in callbacks provided by websocket library. Allows to differentiate between connection status changes, receive the actual payload data, and know which errors may have occurred.
If an error occurs in the websocket connection the integration will reload itself and rely on the standard config flow setup fallback mechanism. Transient errors are still handled in the library, so this should be a rare event.
To go along with this reload, the logging is reduced on initial connection failures as the core logging is sufficient.
Hopefully addresses setups with not-always-up Plex servers: #39979.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: