Add support for "alias" in device, device_condition, and conditions#40772
Add support for "alias" in device, device_condition, and conditions#40772donkawechico wants to merge 2 commits intohome-assistant:devfrom
Conversation
0f5b040 to
2939b94
Compare
2939b94 to
801b27e
Compare
|
We already allow setting an core/homeassistant/helpers/script.py Lines 382 to 383 in b1ba1a7 What would this PR add that is not already there? |
A permanent record of my idiocy in git history? 🤣 How on earth did I miss that. That said, looks, like Guess I'll change this PR to be one that completes the support of ooof. Can we just keep this one between us? |
3fec293 to
81093af
Compare
|
@balloob (and/or others) I've converted the PR from adding unnecessary "description", to one that just adds |
81093af to
d9d4d15
Compare
|
Bump. The frontend just got collapsible panels that would be perfect for the project behind this PR (collapsing sequence steps into panels that are labeled with the alias). |
| def test_action_type_schemas_support_alias(): | ||
| """Test that all action type schemas allow alias field.""" | ||
|
|
||
| def find_root_schema(node): |
There was a problem hiding this comment.
Instead of this, we should embed a config for each notification and error out if we don't have a config for a condition in cv.ACTION_TYPE_SCHEMAS.
| if action_type == cv.SCRIPT_ACTION_CHECK_CONDITION: | ||
| continue |
There was a problem hiding this comment.
I don't see the tests for conditions?
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
See: WTH can’t we annotate sequence steps for logging?.
The backend already has the
aliasfield to mostly achieve this WTH. Butaliasis not supported for all action steps.This PR:
aliasto the following action step type schemas:self._log("Executing step ...into a common methodalias(in case more are ever added)Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: