Skip to content

Pin gRPC to 1.31.0 to workaround amrv7 issues#40678

Merged
balloob merged 2 commits intodevfrom
frenck-2020-0852
Sep 27, 2020
Merged

Pin gRPC to 1.31.0 to workaround amrv7 issues#40678
balloob merged 2 commits intodevfrom
frenck-2020-0852

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Sep 27, 2020

Proposed change

This PR pins (and thus downgrades) the gRPC Python package grpcio from latest release (1.32.0) to the 1.31.0 release.

Main reason for this, is the issue it causes on the armv7 platforms using our containers (and thus wheels).

It seems like it want to use a backtrace, however, that is not available in musl based systems (like Alpine).

While not a solution, we do have working wheels for 1.31.0, and can make multiple integration working again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Sep 27, 2020

Hmm should work, the library is available since: https://github.com/home-assistant/docker/releases/tag/8.1.0

@frenck
Copy link
Copy Markdown
Member Author

frenck commented Sep 27, 2020

@pvizeli Agree, however, it is throwing a symbol not found on backtrace. This rollback would be mainly to send out as a patch for a working situation. I'm not sure about a solution at this point.

@balloob
Copy link
Copy Markdown
Member

balloob commented Sep 27, 2020

I suggest we go with it, get a local repro and fix it in the future.

@balloob balloob merged commit e320c3b into dev Sep 27, 2020
@balloob balloob deleted the frenck-2020-0852 branch September 27, 2020 19:51
@RestOp
Copy link
Copy Markdown

RestOp commented Sep 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Pub/Sub component not working Google Cloud TTS integration failing to load in 0.115

6 participants