Pin gRPC to 1.31.0 to workaround amrv7 issues#40678
Merged
Conversation
MartinHjelmare
approved these changes
Sep 27, 2020
Member
|
Hmm should work, the library is available since: https://github.com/home-assistant/docker/releases/tag/8.1.0 |
Member
Author
|
@pvizeli Agree, however, it is throwing a symbol not found on backtrace. This rollback would be mainly to send out as a patch for a working situation. I'm not sure about a solution at this point. |
Member
|
I suggest we go with it, get a local repro and fix it in the future. |
balloob
pushed a commit
that referenced
this pull request
Sep 28, 2020
Merged
Bre77
pushed a commit
to Bre77/core
that referenced
this pull request
Sep 30, 2020
Bre77
pushed a commit
to Bre77/core
that referenced
this pull request
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR pins (and thus downgrades) the gRPC Python package
grpciofrom latest release (1.32.0) to the 1.31.0 release.Main reason for this, is the issue it causes on the armv7 platforms using our containers (and thus wheels).
It seems like it want to use a backtrace, however, that is not available in musl based systems (like Alpine).
While not a solution, we do have working wheels for 1.31.0, and can make multiple integration working again.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: