Skip to content

Add template cover opening and closing states#40677

Merged
MartinHjelmare merged 3 commits into
home-assistant:devfrom
TheNr1Guest:additional-template-cover-states
Sep 29, 2020
Merged

Add template cover opening and closing states#40677
MartinHjelmare merged 3 commits into
home-assistant:devfrom
TheNr1Guest:additional-template-cover-states

Conversation

@TheNr1Guest
Copy link
Copy Markdown
Contributor

@TheNr1Guest TheNr1Guest commented Sep 27, 2020

Breaking change

Proposed change

Expanding valid states with opening and closing since normal cover components also use these states.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @TheNr1Guest,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Additional 'opening' and 'closing' state. Add template cover opening and closing states Sep 29, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Please update the docs and link a docs PR.

https://www.home-assistant.io/integrations/cover.template/#value_template

@TheNr1Guest
Copy link
Copy Markdown
Contributor Author

Please update the docs and link a docs PR.

https://www.home-assistant.io/integrations/cover.template/#value_template

I just added a PR to the documentation:
home-assistant/home-assistant.io#14646

@MartinHjelmare
Copy link
Copy Markdown
Member

Thanks!

@FrnchFrgg
Copy link
Copy Markdown
Contributor

I will write a PR making value_template and position_template non-exclusive, with value_template taking precedence for the state (and a warning in the documentation that if you use both you are responsible for consistency of the templates).

@FrnchFrgg
Copy link
Copy Markdown
Contributor

(or else you cannot have a template cover with explicit position and opening/closing state)

@TheNr1Guest TheNr1Guest deleted the additional-template-cover-states branch November 16, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants