Use strings instead of f-strings for constants#40619
Merged
frenck merged 6 commits intohome-assistant:devfrom Nov 9, 2020
Merged
Use strings instead of f-strings for constants#40619frenck merged 6 commits intohome-assistant:devfrom
frenck merged 6 commits intohome-assistant:devfrom
Conversation
brefra
reviewed
Sep 26, 2020
frenck
reviewed
Nov 8, 2020
Member
|
@springstan Could you pick up the merge conflict? I've added this PR to my notification list for cleanup after it. |
Member
Author
|
Sure, solved the merge conflicts ✌️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
After the discussion in #40436 (comment) I decided to try and remove as many f-strings from constants.
I have changed the following things and split them up via commits:
There are a lot more constant that use f-strings, but I wanted to correct the most used ones in the code base.
cc @frenck
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: