Skip to content

Allow non-authenticated calls to supervisor logs during onboarding#40617

Merged
ludeeus merged 1 commit intodevfrom
onboarding-supervisor-log
Sep 28, 2020
Merged

Allow non-authenticated calls to supervisor logs during onboarding#40617
ludeeus merged 1 commit intodevfrom
onboarding-supervisor-log

Conversation

@ludeeus
Copy link
Member

@ludeeus ludeeus commented Sep 26, 2020

Breaking change

Proposed change

This will allow the user to show supervisor logs during onboarding.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ludeeus ludeeus merged commit 953f6ba into dev Sep 28, 2020
@ludeeus ludeeus deleted the onboarding-supervisor-log branch September 28, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants