Skip to content

Add installation type to discovery endpoint#40585

Merged
springstan merged 1 commit intodevfrom
discovery-installation-type
Sep 26, 2020
Merged

Add installation type to discovery endpoint#40585
springstan merged 1 commit intodevfrom
discovery-installation-type

Conversation

@ludeeus
Copy link
Member

@ludeeus ludeeus commented Sep 25, 2020

Breaking change

Proposed change

Adds the installation type to the discovery API

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (api) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@springstan springstan merged commit 4a63b83 into dev Sep 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the discovery-installation-type branch September 26, 2020 07:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants