Skip to content

Bump Plugwise-Smile to v1.5.1#40572

Merged
springstan merged 2 commits intohome-assistant:devfrom
plugwise:plugwise-firmware
Sep 25, 2020
Merged

Bump Plugwise-Smile to v1.5.1#40572
springstan merged 2 commits intohome-assistant:devfrom
plugwise:plugwise-firmware

Conversation

@bouwew
Copy link
Copy Markdown
Contributor

@bouwew bouwew commented Sep 25, 2020

Breaking change

Proposed change

Update the Plugwise library: https://github.com/plugwise/Plugwise-Smile/blob/master/CHANGELOG.md

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

The new version no longer blocks minor-version firmware updates, only major-version updates.
We expect no to limited breakage from minor-version firmware updates.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @CoMPaTech, mind taking a look at this pull request as its been labeled with an integration (plugwise) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @bouwew should we tag this for 0.115.4?

@bouwew
Copy link
Copy Markdown
Contributor Author

bouwew commented Sep 25, 2020

Yes, please! The sooner this change is available to the users, the lesser the chance of users running into the issue listed in #40543.

@springstan springstan added this to the 0.115.4 milestone Sep 25, 2020
@springstan springstan merged commit b6aa290 into home-assistant:dev Sep 25, 2020
balloob pushed a commit that referenced this pull request Sep 28, 2020
@balloob balloob mentioned this pull request Sep 28, 2020
@CoMPaTech CoMPaTech deleted the plugwise-firmware branch March 13, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New firmware breaks the Plugwise integration

5 participants