Fix logbook with empty filter and remove unused code#40565
Merged
balloob merged 5 commits intohome-assistant:devfrom Sep 30, 2020
Merged
Fix logbook with empty filter and remove unused code#40565balloob merged 5 commits intohome-assistant:devfrom
balloob merged 5 commits intohome-assistant:devfrom
Conversation
Tweak timestamp conversion
d48e9f6 to
b7859a0
Compare
4 tasks
bdraco
commented
Sep 28, 2020
balloob
approved these changes
Sep 30, 2020
Bre77
pushed a commit
to Bre77/core
that referenced
this pull request
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Remove unused code in logbook. This code is no longer used after the last round of refactoring and cleanups.
Tweak timestamp conversion and reorder code (elif was missing)
Fixes the empty config case @bramkragten pointed out here home-assistant/frontend#6978 (comment)
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: