Skip to content

Fix logbook with empty filter and remove unused code#40565

Merged
balloob merged 5 commits intohome-assistant:devfrom
bdraco:logbook_cleanups
Sep 30, 2020
Merged

Fix logbook with empty filter and remove unused code#40565
balloob merged 5 commits intohome-assistant:devfrom
bdraco:logbook_cleanups

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Sep 25, 2020

Proposed change

Remove unused code in logbook. This code is no longer used after the last round of refactoring and cleanups.

Tweak timestamp conversion and reorder code (elif was missing)

Fixes the empty config case @bramkragten pointed out here home-assistant/frontend#6978 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco changed the title Remove unused code in logbook Fix logbook with empty filter and remove unused code Sep 28, 2020
@balloob balloob merged commit aada6a1 into home-assistant:dev Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants