Skip to content

Use HA constants for Rfxtrx units#40562

Merged
cgarwood merged 7 commits intohome-assistant:devfrom
elupus:rfxtrx_units
Sep 25, 2020
Merged

Use HA constants for Rfxtrx units#40562
cgarwood merged 7 commits intohome-assistant:devfrom
elupus:rfxtrx_units

Conversation

@elupus
Copy link
Copy Markdown
Contributor

@elupus elupus commented Sep 24, 2020

Proposed change

Adjust units of sensors based on supplier information

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • [C] I have followed the development checklist
  • [C] The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with an integration (rfxtrx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/rfxtrx/__init__.py Outdated
Comment thread homeassistant/components/rfxtrx/__init__.py Outdated
@springstan springstan changed the title Rfxtrx units Use HA constants for Rfxtrx units Sep 25, 2020
("Humidity status", None),
("Forecast", None),
("Forecast numeric", None),
("Rain total", "mm"),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LENGTH_MILLIMETERS

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cgarwood cgarwood merged commit 0fbeb3b into home-assistant:dev Sep 25, 2020
@elupus elupus deleted the rfxtrx_units branch September 25, 2020 15:46
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants