Skip to content

Bump aioshelly library to version 0.3.3#40415

Merged
balloob merged 7 commits intohome-assistant:devfrom
bieniu:shelly-firmware-check
Sep 26, 2020
Merged

Bump aioshelly library to version 0.3.3#40415
balloob merged 7 commits intohome-assistant:devfrom
bieniu:shelly-firmware-check

Conversation

@bieniu
Copy link
Copy Markdown
Member

@bieniu bieniu commented Sep 21, 2020

Breaking change

Proposed change

This PR bumps aioshelly library to version 0.3.3 to:

  • abort Shelly integration config flow if device firmware version is unupported

Changelog: home-assistant-libs/aioshelly@0.3.2...0.3.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @balloob, mind taking a look at this pull request as its been labeled with an integration (shelly) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bieniu bieniu closed this Sep 21, 2020
@bieniu bieniu reopened this Sep 23, 2020
@bieniu bieniu marked this pull request as draft September 23, 2020 15:53
@bieniu bieniu changed the title Abort Shelly config flow if the device firmware is unsupported Bump aioshelly library to version 0.3.3 Sep 24, 2020
@bieniu bieniu marked this pull request as ready for review September 24, 2020 15:13
@balloob balloob merged commit b8f8373 into home-assistant:dev Sep 26, 2020
@bieniu bieniu deleted the shelly-firmware-check branch September 26, 2020 21:20
@bieniu
Copy link
Copy Markdown
Member Author

bieniu commented Sep 27, 2020

Could this change be tagged 0.115.4?

@MartinHjelmare MartinHjelmare added this to the 0.115.4 milestone Sep 27, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

Tagged it, but the beta is on Wednesday so there might not be another patch release for 0.115.

@bieniu
Copy link
Copy Markdown
Member Author

bieniu commented Sep 27, 2020

Yes, I know, thanks.

@balloob balloob mentioned this pull request Sep 28, 2020
Bre77 pushed a commit to Bre77/core that referenced this pull request Sep 30, 2020
Bre77 pushed a commit to Bre77/core that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shelly ramdom device failed to integrate.

4 participants