Skip to content

Fix coolmaster.info#40240

Merged
balloob merged 1 commit intohome-assistant:devfrom
OnFreund:coolmaster_build_date
Sep 18, 2020
Merged

Fix coolmaster.info#40240
balloob merged 1 commit intohome-assistant:devfrom
OnFreund:coolmaster_build_date

Conversation

@OnFreund
Copy link
Contributor

Proposed change

Fix calls to coolmaster.info() failing due to value containing colons.
Diff:
OnFreund/pycoolmasternet-async@v0.1.1...OnFreund:v0.1.2

I cannot test locally since my coolmaster doesn't return these values.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob added this to the 0.115.1 milestone Sep 18, 2020
@balloob balloob merged commit 4cd876f into home-assistant:dev Sep 18, 2020
@OnFreund OnFreund deleted the coolmaster_build_date branch September 18, 2020 13:47
balloob pushed a commit that referenced this pull request Sep 18, 2020
@balloob balloob mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with CoolMasterNet

3 participants