Skip to content

Handle systems without groups#40238

Merged
balloob merged 1 commit intohome-assistant:devfrom
OnFreund:risco_no_groups
Sep 18, 2020
Merged

Handle systems without groups#40238
balloob merged 1 commit intohome-assistant:devfrom
OnFreund:risco_no_groups

Conversation

@OnFreund
Copy link
Contributor

Proposed change

Systems that don't support group arming (A/B/C/D) cause an error when partially armed. This bumps the pyrisco dependency to a version that gracefully handles it.
Since my system supports groups, I cannot test this locally.
The diff in the package:
OnFreund/pyrisco@v0.3.0...v0.3.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

115.0 Risco Alarm => part_arm state not working : TypeError: 'NoneType' object is not iterable

3 participants