Skip to content

Log template listeners when debug logging is on #40180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 5 commits into from
Sep 17, 2020
Merged

Log template listeners when debug logging is on #40180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9b3b5c
Log template listeners when debug logging is on
bdraco Sep 17, 2020
413e12f
drop copy
bdraco Sep 17, 2020
040046a
only log triggers if we do not filter
bdraco Sep 17, 2020
f148441
rephrase
bdraco Sep 17, 2020
af0fe33
Update tests
bdraco Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions homeassistant/helpers/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,11 @@ def async_setup(self) -> None:

self._last_info = self._info.copy()
self._create_listeners()
_LOGGER.debug(
"Template group %s listens for %s",
self._track_templates,
self.listeners,
)

@property
def listeners(self) -> Dict:
Expand Down Expand Up @@ -726,6 +731,10 @@ def _refresh(self, event: Optional[Event]) -> None:
):
continue

_LOGGER.debug(
"Template update %s triggered by event: %s", template.template, event
)

self._info[template] = template.async_render_to_info(
track_template_.variables
)
Expand All @@ -751,6 +760,11 @@ def _refresh(self, event: Optional[Event]) -> None:

if info_changed:
self._update_listeners()
_LOGGER.debug(
"Template group %s listens for %s",
self._track_templates,
self.listeners,
)
self._last_info = self._info.copy()

if not updates:
Expand Down
2 changes: 1 addition & 1 deletion tests/helpers/test_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ def error_callback(entity_id, old_state, new_state):
hass.states.async_set("switch.not_exist", "off")
await hass.async_block_till_done()

assert "lunch" not in caplog.text
assert "no filter named 'lunch'" not in caplog.text
assert "TemplateAssertionError" not in caplog.text


Expand Down