Skip to content

Add rpi_power during onboarding on RPi#40076

Merged
balloob merged 5 commits intodevfrom
add-rpi-power-on-supervisor-onboarding
Sep 28, 2020
Merged

Add rpi_power during onboarding on RPi#40076
balloob merged 5 commits intodevfrom
add-rpi-power-on-supervisor-onboarding

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented Sep 14, 2020

Breaking change

Proposed change

  • Add rpi_power during onboarding if Supervisor is set up and machine is RaspberryPi.

Todo

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @shenxn, @swetoast, mind taking a look at this pull request as its been labeled with an integration (rpi_power) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare marked this pull request as ready for review September 14, 2020 18:11
@balloob balloob merged commit eda68f1 into dev Sep 28, 2020
@balloob balloob deleted the add-rpi-power-on-supervisor-onboarding branch September 28, 2020 14:07
Bre77 pushed a commit to Bre77/core that referenced this pull request Sep 30, 2020
Bre77 pushed a commit to Bre77/core that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants