Skip to content

Improve Plugwise config_options testing#39736

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
plugwise:plugwise-co_fixes
Sep 7, 2020
Merged

Improve Plugwise config_options testing#39736
MartinHjelmare merged 1 commit intohome-assistant:devfrom
plugwise:plugwise-co_fixes

Conversation

@CoMPaTech
Copy link
Copy Markdown
Member

Proposed change

Improve #37229 from comments after merge

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bouwew, mind taking a look at this pull request as its been labeled with an integration (plugwise) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@CoMPaTech
Copy link
Copy Markdown
Member Author

Suggested by comments #37229 (comment) and #37229 (comment)

@CoMPaTech CoMPaTech marked this pull request as ready for review September 7, 2020 07:53
@CoMPaTech
Copy link
Copy Markdown
Member Author

@MartinHjelmare I hope I interpreted the second command the way you indicated

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks!

@MartinHjelmare MartinHjelmare merged commit f6aa3e0 into home-assistant:dev Sep 7, 2020
@CoMPaTech CoMPaTech deleted the plugwise-co_fixes branch September 7, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants