Skip to content

Add Tasmota integration#39624

Merged
emontnemery merged 25 commits intohome-assistant:devfrom
emontnemery:tasmota_mvp
Oct 6, 2020
Merged

Add Tasmota integration#39624
emontnemery merged 25 commits intohome-assistant:devfrom
emontnemery:tasmota_mvp

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Sep 3, 2020

Proposed change

Tasmota integration MVP:

  • Support device registry add/update/remove via discovery messages
  • Support entity registry add/remove via discovery messages
  • Support switch type entities (relay in Tasmota)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@effelle
Copy link
Copy Markdown
Contributor

effelle commented Sep 4, 2020

Ok then! I'll start to create a new ino for that.

Comment thread homeassistant/components/tasmota/manifest.json Outdated
Comment thread homeassistant/components/tasmota/config_flow.py Outdated
Comment thread homeassistant/components/tasmota/config_flow.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be time to introduce a new Integration MQTT discovery type so that the MQTT integration can notify other integrations if it finds data at topics that those integrations can manage.

So in here we would do "mqtt_discovery": "tasmota/#" and if any message comes in, the MQTT integration starts the Tasmota config flow.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great idea and I didn't forget about it!
Let's add MQTT integration discovery in a separate PR though?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss

Comment thread homeassistant/components/tasmota/switch.py Outdated
Comment thread homeassistant/components/tasmota/discovery.py Outdated
Comment thread homeassistant/components/tasmota/__init__.py Outdated
Comment thread homeassistant/components/tasmota/mixins.py Outdated
Comment thread homeassistant/components/tasmota/strings.json Outdated
Comment thread homeassistant/components/tasmota/switch.py Outdated
Comment thread homeassistant/components/tasmota/switch.py Outdated
Comment thread homeassistant/components/tasmota/switch.py Outdated
Comment thread homeassistant/components/tasmota/switch.py Outdated
Comment thread homeassistant/components/tasmota/__init__.py Outdated
Comment thread homeassistant/components/tasmota/discovery.py Outdated
Comment thread homeassistant/components/tasmota/discovery.py Outdated
Comment thread homeassistant/components/tasmota/__init__.py Outdated
Comment thread homeassistant/components/tasmota/discovery.py Outdated
Comment thread homeassistant/components/tasmota/switch.py Outdated
Comment thread homeassistant/components/tasmota/const.py Outdated
Comment thread homeassistant/components/tasmota/const.py Outdated
Comment thread homeassistant/components/tasmota/switch.py Outdated
@emontnemery emontnemery changed the title WIP: Add Tasmota integration Add Tasmota integration Sep 14, 2020
blakadder added a commit to blakadder/brands that referenced this pull request Sep 19, 2020
@blakadder blakadder mentioned this pull request Sep 19, 2020
10 tasks
@blakadder
Copy link
Copy Markdown

brand graphics submitted home-assistant/brands#1868

@effelle
Copy link
Copy Markdown
Contributor

effelle commented Sep 19, 2020

I think Erik did already included it...

@blakadder
Copy link
Copy Markdown

I think Erik did already included it...

but i included it better ;)

Comment thread homeassistant/components/tasmota/__init__.py Outdated
Comment thread homeassistant/components/tasmota/__init__.py Outdated
Comment thread homeassistant/components/tasmota/config_flow.py Outdated
Comment thread homeassistant/components/tasmota/discovery.py Outdated
Comment thread homeassistant/components/tasmota/discovery.py Outdated
Comment thread homeassistant/components/tasmota/switch.py Outdated
Comment thread tests/components/tasmota/conftest.py Outdated
Comment thread tests/components/tasmota/test_discovery.py Outdated
Comment thread homeassistant/components/tasmota/mixins.py Outdated
Comment thread homeassistant/components/tasmota/mixins.py Outdated
Comment thread tests/components/tasmota/test_discovery.py Outdated
Comment thread tests/components/tasmota/test_common.py Outdated
Comment thread tests/components/tasmota/test_common.py Outdated
Comment thread tests/components/tasmota/test_common.py Outdated
Comment thread homeassistant/components/mqtt/__init__.py Outdated
Comment thread tests/components/tasmota/test_common.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare
Copy link
Copy Markdown
Member

Please link a docs PR in the PR description. Then we can merge.

@emontnemery emontnemery merged commit 06e9489 into home-assistant:dev Oct 6, 2020
frenck pushed a commit to home-assistant/brands that referenced this pull request Oct 12, 2020
@emontnemery emontnemery deleted the tasmota_mvp branch October 14, 2020 17:49
@ahmetem
Copy link
Copy Markdown

ahmetem commented Oct 29, 2020

Hi,
Can it be integration IRHVAC ?
if i will be great :)

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Oct 29, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 30, 2020

@ahmetem Please use our community forum for feature requests. Thanks 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants