Skip to content

Support reloading the smtp notify platform#39530

Merged
bdraco merged 2 commits intohome-assistant:devfrom
bdraco:smtp_reload_notify
Sep 3, 2020
Merged

Support reloading the smtp notify platform#39530
bdraco merged 2 commits intohome-assistant:devfrom
bdraco:smtp_reload_notify

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Aug 31, 2020

Requires #39527

WTH: https://community.home-assistant.io/t/why-the-heck-is-a-restart-needed-for-each-an-every-change-to-configuration-yaml/219630/10?u=bdraco

Proposed change

Support reloading the smtp notify platform

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as its been labeled with an integration (smtp) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco added the WTH Issues & PRs generated from the "Month of What the Heck?" label Aug 31, 2020
@bdraco bdraco force-pushed the smtp_reload_notify branch 3 times, most recently from a90d1ed to 5cf4abd Compare August 31, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants