Skip to content

Support reloading the group notify platform#39511

Merged
balloob merged 20 commits intohome-assistant:devfrom
bdraco:reset_support_notify_platforms
Sep 2, 2020
Merged

Support reloading the group notify platform#39511
balloob merged 20 commits intohome-assistant:devfrom
bdraco:reset_support_notify_platforms

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Aug 31, 2020

WTH: https://community.home-assistant.io/t/why-the-heck-is-a-restart-needed-for-each-an-every-change-to-configuration-yaml/219630/10?u=bdraco

Frontend PR home-assistant/frontend#6759

Proposed change

Support reloading the group notify platform

Add support to resetup notify platforms

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco added the WTH Issues & PRs generated from the "Month of What the Heck?" label Aug 31, 2020
@bdraco bdraco force-pushed the reset_support_notify_platforms branch from 2c5f547 to c6d7f65 Compare August 31, 2020 16:48
@bdraco
Copy link
Member Author

bdraco commented Aug 31, 2020

Unrelated test failure is #39519

@bdraco
Copy link
Member Author

bdraco commented Aug 31, 2020

Unrelated test failure is #39523

@bdraco bdraco marked this pull request as ready for review August 31, 2020 18:11
@bdraco bdraco force-pushed the reset_support_notify_platforms branch from 0aca233 to e6db54f Compare August 31, 2020 21:22
@bdraco bdraco force-pushed the reset_support_notify_platforms branch 2 times, most recently from d846ad7 to 9881006 Compare September 2, 2020 14:34
@bdraco bdraco force-pushed the reset_support_notify_platforms branch from b2e79cf to ed0e742 Compare September 2, 2020 16:56
@bdraco bdraco requested a review from balloob September 2, 2020 19:50
@balloob balloob merged commit a778690 into home-assistant:dev Sep 2, 2020
@bdraco
Copy link
Member Author

bdraco commented Sep 2, 2020

Thanks @balloob. Unblocked now 😄

@raman325
Copy link
Contributor

raman325 commented Sep 17, 2020

@bdraco I can't say for sure, but I suspect something about the change here has led to: #40184

The apprise code hasn't been changed in a while and the function call that's triggering the warning is within send_message so it shouldn't be a problem with the apprise integration itself. Mind taking a look?

@bdraco
Copy link
Member Author

bdraco commented Sep 17, 2020

@raman325 This one is odd since the code to call send_message hasn't changed either.

    def send_message(self, message, **kwargs):
        """Send a message.

        kwargs can contain ATTR_TITLE to specify a title.
        """
        raise NotImplementedError()

    async def async_send_message(self, message: Any, **kwargs: Any) -> None:
        """Send a message.

        kwargs can contain ATTR_TITLE to specify a title.
        """
        await self.hass.async_add_job(partial(self.send_message, message, **kwargs))  # type: ignore

@raman325
Copy link
Contributor

Yeah I can't make sense of it. Could it be a false firing of the error?

@caronc caronc mentioned this pull request Sep 18, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed core has-tests integration: group integration: notify WTH Issues & PRs generated from the "Month of What the Heck?"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants