Support reloading the group notify platform#39511
Merged
balloob merged 20 commits intohome-assistant:devfrom Sep 2, 2020
Merged
Support reloading the group notify platform#39511balloob merged 20 commits intohome-assistant:devfrom
balloob merged 20 commits intohome-assistant:devfrom
Conversation
2c5f547 to
c6d7f65
Compare
Member
Author
|
Unrelated test failure is #39519 |
Member
Author
|
Unrelated test failure is #39523 |
21 tasks
0aca233 to
e6db54f
Compare
9 tasks
balloob
reviewed
Sep 2, 2020
balloob
reviewed
Sep 2, 2020
d846ad7 to
9881006
Compare
Add support to resetup notify platforms
b2e79cf to
ed0e742
Compare
balloob
approved these changes
Sep 2, 2020
Member
Author
|
Thanks @balloob. Unblocked now 😄 |
Contributor
|
@bdraco I can't say for sure, but I suspect something about the change here has led to: #40184 The apprise code hasn't been changed in a while and the function call that's triggering the warning is within |
Member
Author
|
@raman325 This one is odd since the code to call send_message hasn't changed either. |
Contributor
|
Yeah I can't make sense of it. Could it be a false firing of the error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WTH: https://community.home-assistant.io/t/why-the-heck-is-a-restart-needed-for-each-an-every-change-to-configuration-yaml/219630/10?u=bdraco
Frontend PR home-assistant/frontend#6759
Proposed change
Support reloading the group notify platform
Add support to resetup notify platforms
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: