Skip to content

Fix smappee supported configurations and device class for voltage sensors#37595

Merged
bdraco merged 1 commit into
home-assistant:devfrom
bsmappee:issue-smappee-37489
Jul 7, 2020
Merged

Fix smappee supported configurations and device class for voltage sensors#37595
bdraco merged 1 commit into
home-assistant:devfrom
bsmappee:issue-smappee-37489

Conversation

@bsmappee
Copy link
Copy Markdown
Contributor

@bsmappee bsmappee commented Jul 7, 2020

Proposed change

Some Smappee sensors set the device class to a list. This prevented HomeKit from starting.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
smappee:
    client_id: 1234
    client_secret: 5678

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • [ x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare MartinHjelmare changed the title Place supported configurations after device class for voltage sensors Fix smappee supported configurations and device class for voltage sensors Jul 7, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bdraco bdraco added this to the 0.112.4 milestone Jul 7, 2020
@bdraco bdraco merged commit 6b97b4f into home-assistant:dev Jul 7, 2020
@balloob balloob mentioned this pull request Jul 9, 2020
hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration Smappee not working correctly Smappee sets device class to a list which prevents homekit from starting

5 participants