Update wake_on_lan parameter

[MattXcz]

Adding default port for WOL

Proposed change

Type of change

adding default value for WOL (port 9)

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

broadcast_port: "9"

Additional information

• This PR fixes or closes issue: fixes from 0.112.0, wake_on_line does not function #37399
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[cgtobi]

LGTM

[balloob]

The address also requires a default. For both, please use the DEFAULT_ parameters in the wakeonlan package. https://github.com/remcohaszing/pywakeonlan/blob/master/wakeonlan.py

[balloob]

Alternative is to not pass the args at all to the wlan function.

kwargs = {}
if CONF_BROADCAST_PORT in call.data:
    kwargs['port'] = call.data[CONF_BROADCASTPORT]

await hass.async_add_job(
    partial(
        wakeonlan.send_magic_packet,
        mac_address,
        **kwargs,
    )
)

btw this is also broken in the __init__.py service.

[stshontikidis]

@balloob I have had a PR to fix this as well that sort of takes this approach. #37387

looks like there might be duplicate issues for the port option addition. I would not default the port in HA but leave that up to the library at this time.

[stshontikidis]

This will still leave the turn_on() service in a broken state since it only checks for the broadcast_address to add the kwargs so if a user only sets a port in their config that will never be passed to the actual send_magic_packet() service. Further it will still log the port giving the user bad debug info.

[balloob]

Closing this in favor of #37387