Skip to content

Add helpers.location.coordinates#37234

Merged
balloob merged 6 commits into
home-assistant:devfrom
eifinger:location_helper_coordinates
Jul 3, 2020
Merged

Add helpers.location.coordinates#37234
balloob merged 6 commits into
home-assistant:devfrom
eifinger:location_helper_coordinates

Conversation

@eifinger
Copy link
Copy Markdown
Contributor

Proposed change

This PR adds the required functionality to define dynamic travel_time sensors. The issue was discussed several times in the forum here and here as well as in the PRs #27237 #28716.
After the discussions in those two PRs I added the function as a template with PR #30019. There it was discussed that it would be better placed under homeassistant.helpers.location.

This feature can be used by all existing travel_time integrations. It will be added to here_travel_time in a separate PR and will be added to PR #28910.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/helpers/location.py Outdated
Comment thread homeassistant/helpers/location.py Outdated
Comment thread homeassistant/helpers/location.py Outdated
@eifinger eifinger force-pushed the location_helper_coordinates branch from 9d11e1d to 3a75c95 Compare July 2, 2020 08:26
Comment thread homeassistant/helpers/location.py Outdated
@balloob balloob merged commit eb66da6 into home-assistant:dev Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants