Add helpers.location.coordinates#37234
Merged
Merged
Conversation
9 tasks
balloob
reviewed
Jun 29, 2020
balloob
approved these changes
Jun 29, 2020
balloob
reviewed
Jun 29, 2020
9d11e1d to
3a75c95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds the required functionality to define dynamic
travel_timesensors. The issue was discussed several times in the forum here and here as well as in the PRs #27237 #28716.After the discussions in those two PRs I added the function as a template with PR #30019. There it was discussed that it would be better placed under
homeassistant.helpers.location.This feature can be used by all existing
travel_timeintegrations. It will be added tohere_travel_timein a separate PR and will be added to PR #28910.Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: