Skip to content

Fix MQTT cover custom position range#36222

Merged
bachya merged 1 commit into
home-assistant:devfrom
emontnemery:mqtt_cover_range
May 28, 2020
Merged

Fix MQTT cover custom position range#36222
bachya merged 1 commit into
home-assistant:devfrom
emontnemery:mqtt_cover_range

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Fix MQTT cover custom position range

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bachya bachya merged commit 31250ea into home-assistant:dev May 28, 2020
balloob pushed a commit that referenced this pull request May 28, 2020
@balloob balloob mentioned this pull request May 28, 2020
@emontnemery emontnemery deleted the mqtt_cover_range branch June 10, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard-coded limit for position at cover.set_cover_position

4 participants