Skip to content

Revert DSMR not calling entity methods#36179

Merged
balloob merged 2 commits intodevfrom
revert-dsmr
May 27, 2020
Merged

Revert DSMR not calling entity methods#36179
balloob merged 2 commits intodevfrom
revert-dsmr

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 26, 2020

Breaking change

Proposed change

When I cleaned up integrations calling update_ha_state (#33513), I broke multiple instances of DSMR. This PR reverts it.

Fixes #35879

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob added this to the 0.110.4 milestone May 26, 2020
@balloob balloob merged commit cfaa851 into dev May 27, 2020
@balloob balloob deleted the revert-dsmr branch May 27, 2020 05:11
balloob added a commit that referenced this pull request May 28, 2020
@balloob balloob mentioned this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple DSMR integrations broken after 0.109

2 participants