Skip to content

Fix Devolo cloud connection within API#36158

Merged
frenck merged 1 commit into
home-assistant:devfrom
2Fake:fix_devolo_cloud_connection
May 26, 2020
Merged

Fix Devolo cloud connection within API#36158
frenck merged 1 commit into
home-assistant:devfrom
2Fake:fix_devolo_cloud_connection

Conversation

@2Fake
Copy link
Copy Markdown
Contributor

@2Fake 2Fake commented May 26, 2020

Breaking change

Proposed change

Bump API version to keep a cloud session alive.

Release notes: https://github.com/2Fake/devolo_home_control_api/releases/tag/v0.11.0
Changelog: 2Fake/devolo_home_control_api@v0.10.0...v0.11.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

The issue was fixed in the underlying API see here

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added bugfix integration: devolo_home_control small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file by-code-owner labels May 26, 2020
@probot-home-assistant
Copy link
Copy Markdown

Hey there @Shutgun, mind taking a look at this pull request as its been labeled with a integration (devolo_home_control) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck
Copy link
Copy Markdown
Member

frenck commented May 26, 2020

@2Fake I've updated the PR description with links to the changelog and release notes. Please make sure you include them next time, as it saves us the need to search for them.

Looking at the changes upstream, it is not just a fix, but there is a whole bunch of new features implemented. From question on Discord, I understand you wanted this to go into a patch release. However, I'm not sure if that is a safe thing, considering all the changes.

Can you elaborate on that?

@2Fake
Copy link
Copy Markdown
Contributor Author

2Fake commented May 26, 2020

@frenck You are right, that the API can do more, but home assistant will not use them, because the integration will just use the binary switches delivered by the API. The other devices will come with another pull request. The important file for this integration in the API is properties/binary_switch_property.py. This file was not touched in this release.

The change we need merged into home assistant is in the file backend/mprm_websocket in function _on_pong()
There are a bunch new files in the API, but this will just enable the API to gather data from devices which have other functions than a binary switch. For example a dimmer. But this will not affect the binary switches provided to home assistant

@frenck frenck added this to the 0.110.4 milestone May 26, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @2Fake 👍

@frenck frenck merged commit bc1dac8 into home-assistant:dev May 26, 2020
@frenck frenck changed the title Fix cloud connection within API Fix Devolo cloud connection within API May 27, 2020
balloob pushed a commit that referenced this pull request May 28, 2020
@balloob balloob mentioned this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants