Skip to content

Ensure homekit bridge state is restored before creating devices#36098

Merged
bdraco merged 3 commits intohome-assistant:devfrom
bdraco:ensure_virtual_bridge_state_restored
May 25, 2020
Merged

Ensure homekit bridge state is restored before creating devices#36098
bdraco merged 3 commits intohome-assistant:devfrom
bdraco:ensure_virtual_bridge_state_restored

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 24, 2020 •
edited
Loading

Proposed change

Ensure homekit bridge state is restored before creating devices

This fixes a bug were a new bridge would be created every time options were edited.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco added this to the 0.110.3 milestone May 25, 2020
@bdraco bdraco marked this pull request as ready for review May 25, 2020 04:13
MartinHjelmare
MartinHjelmare reviewed May 25, 2020
View reviewed changes
Comment thread homeassistant/components/homekit/__init__.py Outdated
MartinHjelmare
MartinHjelmare approved these changes May 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bdraco bdraco merged commit 4313d4b into home-assistant:dev May 25, 2020
frenck pushed a commit that referenced this pull request May 26, 2020
@bdraco @frenck
Ensure homekit bridge state is restored before creating devices (#36098)
a656a40 
* Ensure homekit bridge state is restored before creating devices

* Tests to ensure homekit device registry entry is stable

* remove stray continue
@frenck frenck mentioned this pull request May 26, 2020
Merged
@aptonline
Copy link
Copy Markdown

aptonline commented May 26, 2020

Working for me now, well done guys :)

@bdraco bdraco deleted the ensure_virtual_bridge_state_restored branch May 26, 2020 13:55
@home-assistant home-assistant locked as resolved and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

by-code-owner cherry-picked cla-signed integration: homekit

Projects

None yet

Milestone

0.110.3

Development

Successfully merging this pull request may close these issues.

Changing HomeKit options in the integrations panel adds another HomeKit bridge

5 participants

@bdraco @aptonline @MartinHjelmare @frenck @homeassistant