Skip to content

Fix bugs with AirVisual auto-leveling API#36097

Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom
bachya:airvisual-bug
May 26, 2020
Merged

Fix bugs with AirVisual auto-leveling API#36097
MartinHjelmare merged 3 commits intohome-assistant:devfrom
bachya:airvisual-bug

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented May 24, 2020

Proposed change

#34903 introduced an "auto-leveling" mechanism for AirVisual's API, but there were several bugs:

  1. Adding any additional AirVisual integration (even those with a different API key, Node/Pro units [which don't use the cloud API], etc.) would cause the update interval to auto-level. This PR fixes that so auto-leveling only occurs when the same API key is used.
  2. The integration didn't properly auto-level when instances were removed. This PR fixes that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/airvisual/__init__.py Outdated
Comment thread homeassistant/components/airvisual/__init__.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 599d3ae into home-assistant:dev May 26, 2020
frenck pushed a commit that referenced this pull request May 26, 2020
* Fix bugs with AirVisual auto-leveling API

* Code review

* Code review
@frenck frenck mentioned this pull request May 26, 2020
@bachya bachya deleted the airvisual-bug branch May 27, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants