Skip to content

Fix roku play/pause during standby#36096

Merged
frenck merged 1 commit intodevfrom
ctalkington-roku-play-standby
May 25, 2020
Merged

Fix roku play/pause during standby#36096
frenck merged 1 commit intodevfrom
ctalkington-roku-play-standby

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented May 24, 2020

Breaking change

Proposed change

Roku doesn't like being passed play/pause while in standby. It just results in timeout.

This change prevents play/pause when state is STATE_STANDBY.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ctalkington 👍

@frenck frenck merged commit 77eab66 into dev May 25, 2020
@frenck frenck deleted the ctalkington-roku-play-standby branch May 25, 2020 11:55
frenck pushed a commit that referenced this pull request May 26, 2020
@frenck frenck mentioned this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.110.x Roku Timeout error when media_play_pause command issued on standby

3 participants