Fix emulated_hue compatibility with older devices#36090
Merged
bdraco merged 3 commits intohome-assistant:devfrom May 25, 2020
Merged
Fix emulated_hue compatibility with older devices#36090bdraco merged 3 commits intohome-assistant:devfrom
bdraco merged 3 commits intohome-assistant:devfrom
Conversation
Member
|
Edit: looks like the breaking change occurred in a separate PR, will submit a PR to update release post: #35998 (comment) |
Member
|
I'll test this as soon as I can (should be later tonight) |
Member
|
Seeing both with netdisco |
Member
|
Discovered ok on harmony 2400 |
Member
|
Discovered ok on wifi hub |
bdraco
approved these changes
May 25, 2020
frenck
pushed a commit
that referenced
this pull request
May 26, 2020
* Fix emulated_hue compatibility with older devices * Fix test ugliness * Fix pylint errors
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Restore
emulated_huecompatibility with older devices, especially Logitech Harmony Hubs.#35148 changed the
emulated_huediscovery process to work with newer devices. It responds to UPnP queries with aST: upnp:rootdevice, which was assumed to be supported by all devices. However, older devices only work withST: urn:schemas-upnp-org:device:basic:1.This also adds a desperately needed test for the discovery response packet.
Tested with the following devices:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: