Skip to content

Re-read last imap_email_content email when no change #36065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 3 commits into from
May 25, 2020
Merged

Re-read last imap_email_content email when no change #36065

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a4a830
Try to fix #35975 - re-read last email when no change
isk0001y May 22, 2020
4a4b506
Merge branch 'dev' of https://github.com/home-assistant/core into fea…
isk0001y May 24, 2020
696a8c8
nomessage1: try to catch 2 more cases in a meaningful way
isk0001y May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions homeassistant/components/imap_email_content/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ def _fetch_message(self, message_uid):

if message_data is None:
return None
if message_data[0] is None:
Comment thread
MartinHjelmare marked this conversation as resolved.
return None
raw_email = message_data[0][1]
email_message = email.message_from_bytes(raw_email)
return email_message
Expand All @@ -126,13 +128,22 @@ def read_next(self):
self._last_id = int(message_uid)
return self._fetch_message(message_uid)

return self._fetch_message(str(self._last_id))

except imaplib.IMAP4.error:
_LOGGER.info("Connection to %s lost, attempting to reconnect", self._server)
try:
self.connect()
_LOGGER.info(
"Reconnect to %s succeeded, trying last message", self._server
)
if self._last_id is not None:
return self._fetch_message(str(self._last_id))
except imaplib.IMAP4.error:
_LOGGER.error("Failed to reconnect")

return None


class EmailContentSensor(Entity):
"""Representation of an EMail sensor."""
Expand Down