Skip to content

Update environment_canada camera#36010

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
michaeldavie:env_canada_38
May 23, 2020
Merged

Update environment_canada camera#36010
MartinHjelmare merged 2 commits intohome-assistant:devfrom
michaeldavie:env_canada_38

Conversation

@michaeldavie
Copy link
Copy Markdown
Contributor

@michaeldavie michaeldavie commented May 23, 2020

Breaking Change

The radar imagery used is no longer associated with fixed radar stations. As a result:

  • The station and location attributes have been removed
  • Entity names will change, as they are no longer related to the value of the station attribute

The integration can still be configured using a station identification code, so existing configurations using this method remain valid.

Proposed change

Use upgraded env_canada library:

  • Removes use of web scraping for radar imagery
  • Uses Government of Canada web map services to dynamically generate basemap and radar imagery for any Canadian location

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
camera:
  - platform: environment_canada
    latitude: 50
    longitude: -100

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/environment_canada/camera.py
Comment thread homeassistant/components/environment_canada/camera.py
@michaeldavie michaeldavie changed the title Bump env_canada to 0.0.38 Update environment_canada camera May 23, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Platform error camera.environment_canada - No module named 'bs4'

3 participants