Skip to content

Fix ONVIF PTZ and profile encoding issues#36006

Merged
hunterjm merged 5 commits intohome-assistant:devfrom
hunterjm:bugfix/onvif-ptz
May 23, 2020
Merged

Fix ONVIF PTZ and profile encoding issues#36006
hunterjm merged 5 commits intohome-assistant:devfrom
hunterjm:bugfix/onvif-ptz

Conversation

@hunterjm
Copy link
Copy Markdown
Member

Proposed change

Catch some additional errors that came up with different devices. This one closes a lot of tickets!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@hunterjm hunterjm added this to the 0.110.2 milestone May 23, 2020
@frenck frenck self-assigned this May 23, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@hunterjm hunterjm changed the title Bugfix/onvif ptz Fix ONVIF PTZ and profile encoding issues May 23, 2020
@frenck frenck removed their assignment May 23, 2020
@hunterjm hunterjm merged commit 0514960 into home-assistant:dev May 23, 2020
@hunterjm hunterjm deleted the bugfix/onvif-ptz branch May 23, 2020 02:12
@olealm
Copy link
Copy Markdown

olealm commented May 23, 2020

Maybe not relevant and maybe a bit late to the party, but checked all my 3 problematic cameras (unique ID). Mac IS returned for all at least using ONVIF device manager, but it is interpreted as "Hardware", not "Mac". Same for all 3 cameras (2 different brands)
2020-05-23 11_20_29-ONVIF Device Manager v2 2 250

@frenck
Copy link
Copy Markdown
Member

frenck commented May 23, 2020

@olealm This has nothing to do with this PR.
Please use GitHub issues to raise or discuss issues with integrations.

Thanks! 👍

@home-assistant home-assistant locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

4 participants