Skip to content

Bump pyAV and close unclosed outputs#35960

Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom
hunterjm:bugfix/stream-close
May 22, 2020
Merged

Bump pyAV and close unclosed outputs#35960
MartinHjelmare merged 3 commits intohome-assistant:devfrom
hunterjm:bugfix/stream-close

Conversation

@hunterjm
Copy link
Copy Markdown
Member

Proposed change

  1. Bump pyAV to 8.0.1 which includes binaries on pypi for easier installation on manual installs to fix Stream component does not work. (Component error: stream - Requirements for stream not found: [‘av == 7.0.1’]) #35900
  2. Make sure to close all input and output buffers when exiting worker thread to fix 0.110.1 - av.container errors with Camera, Stream, FFMPEG components  #35923

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@hunterjm hunterjm added this to the 0.110.2 milestone May 22, 2020
@probot-home-assistant probot-home-assistant Bot added bugfix core dependency Pull requests marked as a dependency upgrade integration: stream small-pr PRs with less than 30 lines. by-code-owner labels May 22, 2020
Copy link
Copy Markdown
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Comment thread homeassistant/components/stream/worker.py
@MartinHjelmare MartinHjelmare changed the title bump pyAV and close unclosed outputs Bump pyAV and close unclosed outputs May 22, 2020
@hunterjm
Copy link
Copy Markdown
Member Author

This is good to go now.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 8cd9054 into home-assistant:dev May 22, 2020
@hunterjm hunterjm deleted the bugfix/stream-close branch May 23, 2020 02:14
frenck pushed a commit that referenced this pull request May 24, 2020
* bump pyAV and close unclosed outputs

* skip stream from coverage for now

* fix divide by zero error
@frenck frenck mentioned this pull request May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix by-code-owner cherry-picked cla-signed core dependency Pull requests marked as a dependency upgrade integration: stream small-pr PRs with less than 30 lines.

Projects

None yet

6 participants