Skip to content

Update rokuecp to 0.4.1#35899

Merged
MartinHjelmare merged 3 commits intodevfrom
ctalkington-roku-041
May 21, 2020
Merged

Update rokuecp to 0.4.1#35899
MartinHjelmare merged 3 commits intodevfrom
ctalkington-roku-041

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented May 21, 2020 •
edited by MartinHjelmare
Loading

Breaking change

Proposed change

Fixes standby detection.

ctalkington/python-rokuecp@0.4.0...0.4.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added integration: roku small-pr PRs with less than 30 lines. labels May 21, 2020
@probot-home-assistant probot-home-assistant Bot added dependency-bump Pull requests that update a dependency file by-code-owner labels May 21, 2020
@MartinHjelmare MartinHjelmare merged commit 78b5767 into dev May 21, 2020
@delete-merged-branch delete-merged-branch Bot deleted the ctalkington-roku-041 branch May 21, 2020 07:22
@ctalkington ctalkington added this to the 0.110.2 milestone May 21, 2020
@ctalkington
Copy link
Copy Markdown
Contributor Author

ctalkington commented May 21, 2020

@frenck can we merge this into next 110 patch release, its a simple dep update.

@frenck
Copy link
Copy Markdown
Member

frenck commented May 21, 2020

Just marking it on the milestone is enough @ctalkington ;)

frenck pushed a commit that referenced this pull request May 24, 2020
@ctalkington @frenck
Update rokuecp to 0.4.1 (#35899)
8d008d3 
* update rokuecp to 0.4.1

* Update requirements_all.txt

* Update requirements_test_all.txt
@frenck frenck mentioned this pull request May 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

by-code-owner cherry-picked cla-signed dependency-bump Pull requests that update a dependency file integration: roku small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.110.2

Development

Successfully merging this pull request may close these issues.

Roku no longer reports standby state

4 participants

@ctalkington @frenck @MartinHjelmare @homeassistant