Skip to content

Fix Prezzibenzina doing I/O in the event loop#35881

Merged
bachya merged 2 commits intohome-assistant:devfrom
bachya:prezzibenzina-io
May 20, 2020
Merged

Fix Prezzibenzina doing I/O in the event loop#35881
bachya merged 2 commits intohome-assistant:devfrom
bachya:prezzibenzina-io

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented May 20, 2020

Proposed change

This PR fixes Prezzibenzina doing I/O in the event loop. I do not use this integration and have not tested it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bachya bachya merged commit 19573a9 into home-assistant:dev May 20, 2020
@bachya bachya deleted the prezzibenzina-io branch May 20, 2020 22:09
@frenck frenck added this to the 0.110.2 milestone May 21, 2020
frenck pushed a commit that referenced this pull request May 24, 2020
* Fix Prezzibenzina doing I/O in the event loop

* Linting
@frenck frenck mentioned this pull request May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prezzibenzina integration Detected I/O inside the event loop

4 participants