Fix service registration supported features check#35718
Merged
MartinHjelmare merged 8 commits intohome-assistant:devfrom May 23, 2020
Merged
Fix service registration supported features check#35718MartinHjelmare merged 8 commits intohome-assistant:devfrom
MartinHjelmare merged 8 commits intohome-assistant:devfrom
Conversation
20 tasks
Contributor
|
Looks good. Will review once tests pass. |
Contributor
Author
|
Hi @ctalkington, can you look at my changes in roku integration? Seems codeowners bot doesn't work for updated PRs |
Contributor
|
@chmielowiec roku doesnt support pause command though its possible to call play, to pause, just no discrete option |
Contributor
|
working on roku pause updates which had been on my mind anyways due to voice control. should make PR this simplier |
Contributor
Author
@ctalkington Should I rebase onto your branch? |
Contributor
|
I dont think itll merge conflict so no need to do anything atm until one or other is merged |
chmielowiec
force-pushed
the
fix-service-supports-check
branch
from
62e54d7 to
4662311
Compare
MartinHjelmare
requested changes
May 22, 2020
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
chmielowiec
force-pushed
the
fix-service-supports-check
branch
from
73c4c40 to
43ac02a
Compare
Contributor
Author
|
@MartinHjelmare Could you review the source PR #35679 of this bug? It's waiting for more core reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Fixes bug found by @elupus in #35679 (comment)
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: