Use Coerce(float) on service options for kef#35659
Merged
elupus merged 2 commits intohome-assistant:devfrom May 24, 2020
Merged
Use Coerce(float) on service options for kef#35659elupus merged 2 commits intohome-assistant:devfrom
elupus merged 2 commits intohome-assistant:devfrom
Conversation
elupus
reviewed
May 19, 2020
Contributor
elupus
left a comment
There was a problem hiding this comment.
Hmm. Expecting a float value to be in a a list of options is fragile. Floats are non-exact.
Contributor
|
You may want to coerce to a decimal type of fixed precision. |
Contributor
Author
@elupus, thanks for the suggestion! I've looked in the Home Assistant code base but I couldn't find an example of how to do that. Do you know how to do it? |
elupus
approved these changes
May 22, 2020
Contributor
elupus
left a comment
There was a problem hiding this comment.
I think this looks fine. If the value is float in the backend. This doesn't make the issue worse, and if you do change the type later to Decimal. This aught to work too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Coerce to the correct data type.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: