Skip to content

Fix reversed logic in zeroconf homekit pairing check#35596

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
bdraco:zeroconf_sending_too_much_homekit
May 14, 2020
Merged

Fix reversed logic in zeroconf homekit pairing check#35596
MartinHjelmare merged 2 commits intohome-assistant:devfrom
bdraco:zeroconf_sending_too_much_homekit

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 13, 2020

Proposed change

Fix reversed logic in zeroconf homekit pairing check

I reversed the logic in #35545, "1" is unpaired and "0" is paired.

Thanks @bramkragten for pointing this out

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/zeroconf/__init__.py Outdated
@MartinHjelmare MartinHjelmare merged commit a42a654 into home-assistant:dev May 14, 2020
frenck pushed a commit that referenced this pull request May 14, 2020
* Fix reversed logic in zeroconf homekit pairing check

* s/server_info/service_info/
@lock lock Bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants