Add more system information from Supervisor#35560
Conversation
|
Hey there @home-assistant/hass-io, mind taking a look at this pull request as its been labeled with a integration ( |
| Async friendly. | ||
| """ | ||
| return hass.data.get(DATA_HOMEASSISTANT_VERSION) | ||
| if DATA_INFO not in hass.data: |
There was a problem hiding this comment.
Should we do this? I think it would be better to make it fail as it's an unexpected situation. Integrations should depend on hassio if they want to call its methods.
There was a problem hiding this comment.
I know... right now it uses .get() so I assumed it is expected to be None at some point. I wanted to keep that type of "risk" out of the loop now.
We should look at the integration anyways, as some things changed at the Supervisor (new endpoint and variables) that still need to be adjusted.
|
What would be really nice is to have a copy/paste button that gives you the content and formatting that is perfect for pasting into a Github ticket...then the devs always get what they need. |
|
Yes, but that is a frontend thing, this was a backend thing. |
Proposed change
This PR add more system information:
Left = new, Right = current
It enriches the info panel with information about the installation type, so users can look that up easily.
Furthermore, it has been enriched with information from the Supervisor.
It now can show:
vmorembedded)ps: In the above screenshot
dockerandvenvare not correct, since I'm connected to a remote Supervisor with my local Python dev environment in a venv.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: