Skip to content

Add more system information from Supervisor#35560

Merged
balloob merged 1 commit intodevfrom
frenck-2020-0525
May 12, 2020
Merged

Add more system information from Supervisor#35560
balloob merged 1 commit intodevfrom
frenck-2020-0525

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 12, 2020

Proposed change

This PR add more system information:

Left = new, Right = current

image

It enriches the info panel with information about the installation type, so users can look that up easily.

Furthermore, it has been enriched with information from the Supervisor.
It now can show:

  • Host Operating System
  • Chassis (e.g., vm or embedded)
  • Supervisor version

ps: In the above screenshot docker and venv are not correct, since I'm connected to a remote Supervisor with my local Python dev environment in a venv.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/hass-io, mind taking a look at this pull request as its been labeled with a integration (hassio) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Async friendly.
"""
return hass.data.get(DATA_HOMEASSISTANT_VERSION)
if DATA_INFO not in hass.data:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this? I think it would be better to make it fail as it's an unexpected situation. Integrations should depend on hassio if they want to call its methods.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know... right now it uses .get() so I assumed it is expected to be None at some point. I wanted to keep that type of "risk" out of the loop now.

We should look at the integration anyways, as some things changed at the Supervisor (new endpoint and variables) that still need to be adjusted.

@balloob balloob merged commit eddb5c6 into dev May 12, 2020
@balloob balloob deleted the frenck-2020-0525 branch May 12, 2020 22:27
@BradleyFord
Copy link
Copy Markdown

What would be really nice is to have a copy/paste button that gives you the content and formatting that is perfect for pasting into a Github ticket...then the devs always get what they need.

Copy link
Copy Markdown
Member Author

frenck commented May 13, 2020

Yes, but that is a frontend thing, this was a backend thing.

@lock lock Bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update helpers/system_info.py to detect HassOS

4 participants