Skip to content

Fix synology temperature rounding #35556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quentame merged 2 commits into from
May 13, 2020
Merged

Fix synology temperature rounding #35556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcaee5e
Fix synology temperature rounding
shenxn May 12, 2020
b8851ed
Remove stale comment
shenxn May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions homeassistant/components/synology_dsm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ def __init__(self, hass: HomeAssistantType, entry: ConfigEntry):
self._hass = hass
self._entry = entry

self.temp_unit = hass.config.units.temperature_unit

self.dsm: SynologyDSM = None
self.information: SynoDSMInformation = None
self.utilisation: SynoCoreUtilization = None
Expand Down
11 changes: 4 additions & 7 deletions homeassistant/components/synology_dsm/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@
DATA_MEGABYTES,
DATA_RATE_KILOBYTES_PER_SECOND,
DATA_TERABYTES,
PRECISION_TENTHS,
TEMP_CELSIUS,
)
from homeassistant.helpers.dispatcher import async_dispatcher_connect
from homeassistant.helpers.entity import Entity
from homeassistant.helpers.temperature import display_temp
from homeassistant.helpers.typing import HomeAssistantType
from homeassistant.util.temperature import celsius_to_fahrenheit

from . import SynoApi
from .const import (
Expand Down Expand Up @@ -109,7 +110,7 @@ def icon(self) -> str:
def unit_of_measurement(self) -> str:
"""Return the unit the value is expressed in."""
if self.sensor_type in TEMP_SENSORS_KEYS:
return self._api.temp_unit
return self.hass.config.units.temperature_unit
return self._unit

@property
Expand Down Expand Up @@ -186,12 +187,8 @@ def state(self):
return round(attr / 1024.0 ** 4, 2)

# Temperature
if self._api.temp_unit == TEMP_CELSIUS:
# Celsius
return attr
if self.sensor_type in TEMP_SENSORS_KEYS:
# Fahrenheit
return celsius_to_fahrenheit(attr)
return display_temp(self.hass, attr, TEMP_CELSIUS, PRECISION_TENTHS)

return attr

Expand Down