Sense should only load default ssl certificates once to avoid I/O in the event loop#35523
Merged
bdraco merged 1 commit intoMay 12, 2020
Conversation
probot-home-assistant
Bot
added
integration: sense
small-pr
Contributor
|
https://github.com/scottbonline/sense/releases/tag/0.7.2 Release is now available |
When the websocket is created `SSLContext.load_default_certs` is called each time which opens up the system default ssl certs file and reads it in Normally this goes unnoticed, however since there are frequent connects and disconnects of the websocket it was noticeable.
bdraco
force-pushed
the
sense_io_event_loop_from_load_default_certs
branch
from
9faf6e1 to
a157630
Compare
ctalkington
approved these changes
May 12, 2020
Member
Author
|
Thanks @ctalkington |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When the websocket is created
SSLContext.load_default_certsis calledeach time which opens up the system default ssl certs file and reads it in
Normally this goes unnoticed, however since there are frequent connects
and disconnects of the websocket it was noticeable.
Waiting for scottbonline/sense#35
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: