Skip to content

Add binary sensor platform to zwave_mqtt#35519

Merged
MartinHjelmare merged 8 commits intohome-assistant:devfrom
marcelveldt:zwave_mqtt_binary_sensor
May 12, 2020
Merged

Add binary sensor platform to zwave_mqtt#35519
MartinHjelmare merged 8 commits intohome-assistant:devfrom
marcelveldt:zwave_mqtt_binary_sensor

Conversation

@marcelveldt
Copy link
Copy Markdown
Member

@marcelveldt marcelveldt commented May 11, 2020

Proposed change

Adds binary_sensor platform to zwave_mqtt integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

None

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following [Integration Quality Scale][quality-scale]:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare MartinHjelmare changed the title add binary sensor platform to zwave_mqtt Add binary sensor platform to zwave_mqtt May 11, 2020
@marcelveldt
Copy link
Copy Markdown
Member Author

tests are on the way

@probot-home-assistant
Copy link
Copy Markdown

Hey there @cgarwood, @MartinHjelmare, mind taking a look at this pull request as its been labeled with a integration (zwave_mqtt) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let me know if you need help with tests and I can look at that tomorrow.

Comment thread homeassistant/components/zwave_mqtt/binary_sensor.py Outdated
Comment thread homeassistant/components/zwave_mqtt/binary_sensor.py Outdated
Comment thread homeassistant/components/zwave_mqtt/binary_sensor.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Comment thread tests/components/zwave_mqtt/test_binary_sensor.py
@MartinHjelmare MartinHjelmare merged commit 1351ddd into home-assistant:dev May 12, 2020
@lock lock Bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants